Fix #44, #46: roff: Clean up unnecessary dot escaping, fix dot escaping in NF environments #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the escaping for dots at the beginning of a line from the line level (write) to the node level (escape). (That's why some unnecessary escapes remain unchanged.) - This also fixes rtomayko#46 ("roff: dots are not escaped correctly at beginning of line").
Contributor
Author
|
@rtomayko: Any news on this? Just rebased my feature branch to the current master. @thinkerbot provided a different fix for issue #46 in pull request #65, you might want to check that out, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves dot escaping at the beginning of a line from line to node level.
Fixes #44 and #46.
There's probably a better way to do this, but I figured it was at least cleaner than depending on implementation details in the write method which would have been another naïve solution.