Skip to content

Comments

Refactoring#108

Merged
ilyabrin merged 9 commits intomainfrom
refactoring
Sep 20, 2025
Merged

Refactoring#108
ilyabrin merged 9 commits intomainfrom
refactoring

Conversation

@ilyabrin
Copy link
Contributor

  1. Analyzed current testing approach and issues - Identified that VCR was overkill since we were creating mock data anyway
  2. Replaced VCR with Faraday test adapter - Migrated from VCR to Faraday's built-in test adapter
  3. Created test helper for HTTP mocking - Built comprehensive HTTP mocking infrastructure in spec/support/http_stubs.rb
  4. Fixed all existing tests to use new approach - Converted all test files from VCR to Faraday test adapter
  5. Implemented tests for all new services - Created and fixed tests for all 6 new API services
  6. Removed VCR dependencies and files - Completely removed VCR from the project
  7. Run final test suite to ensure all tests pass

@coveralls
Copy link

coveralls commented Sep 19, 2025

Pull Request Test Coverage Report for Build 17872802188

Details

  • 221 of 261 (84.67%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.9%) to 89.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/yandex360/client.rb 19 20 95.0%
lib/yandex360/resources/audit.rb 8 10 80.0%
lib/yandex360/resources/domains.rb 16 20 80.0%
lib/yandex360/resources/dns.rb 13 18 72.22%
lib/yandex360/collection.rb 10 16 62.5%
lib/yandex360/resource.rb 27 34 79.41%
lib/yandex360/resources/two_fa.rb 11 18 61.11%
lib/yandex360/resources/post_settings.rb 13 21 61.9%
Totals Coverage Status
Change from base Build 17865232658: -6.9%
Covered Lines: 338
Relevant Lines: 379

💛 - Coveralls

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ilyabrin ilyabrin merged commit c46cd3c into main Sep 20, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants