-
Notifications
You must be signed in to change notification settings - Fork 445
End to end tests #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
End to end tests #1421
Conversation
@peterzhu2118 and @st0012: I see that there are many failing checks. I'd like to wait for opinions about the test code before addressing the failures (If no one likes this PR, it needs to be closed, not fixed.) |
@st0012 and @peterzhu2118: The checks now all pass, so I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By end to end, I do mean running rdoc
executable directly in tests 👍
But if we do that, we probably don't need most or all the helpers and stuff from XrefTestCase
. Instead, we can create a new IntegrationTestCase
that provides the run_rdoc
method directly.
To be replaced by #1430. |
I think there's been some discussion about end-to-end testing. Here's a start.
There are two questions: