Skip to content

Conversation

BurdetteLamar
Copy link
Member

I think there's been some discussion about end-to-end testing. Here's a start.

There are two questions:

  • Is the community interested in end-to-end testing (and, crucially, willing to review PRs)?
  • Is the structure offered here workable? If not, what would be better?

@BurdetteLamar BurdetteLamar requested a deployment to fork-preview-protection September 6, 2025 23:04 — with GitHub Actions Waiting
@BurdetteLamar BurdetteLamar marked this pull request as draft September 6, 2025 23:05
@BurdetteLamar
Copy link
Member Author

@peterzhu2118 and @st0012: I see that there are many failing checks. I'd like to wait for opinions about the test code before addressing the failures (If no one likes this PR, it needs to be closed, not fixed.)

@BurdetteLamar BurdetteLamar requested a deployment to fork-preview-protection September 11, 2025 21:42 — with GitHub Actions Waiting
@BurdetteLamar BurdetteLamar requested a deployment to fork-preview-protection September 11, 2025 22:03 — with GitHub Actions Waiting
@BurdetteLamar BurdetteLamar requested a deployment to fork-preview-protection September 12, 2025 03:04 — with GitHub Actions Waiting
@BurdetteLamar BurdetteLamar marked this pull request as ready for review September 12, 2025 03:17
@BurdetteLamar
Copy link
Member Author

@st0012 and @peterzhu2118: The checks now all pass, so I think this is ready for review.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By end to end, I do mean running rdoc executable directly in tests 👍
But if we do that, we probably don't need most or all the helpers and stuff from XrefTestCase. Instead, we can create a new IntegrationTestCase that provides the run_rdoc method directly.

@BurdetteLamar BurdetteLamar marked this pull request as draft October 4, 2025 17:05
@BurdetteLamar
Copy link
Member Author

To be replaced by #1430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants