Propagate package/team/codeowner file errors rather than fail silently #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/pttyrswzonym
branch
from
6f81fa0 to
ec41dd2
Compare
hellosweta
approved these changes
Dec 15, 2025
hellosweta
left a comment
hellosweta
left a comment
There was a problem hiding this comment.
Seems reasonable. Can you remind me what inspired this change? Any considerations around how we want to roll out for folks who will now potentially see new errors?
| } | ||
| let file_name = relative_path.file_name().ok_or_else(|| { | ||
| error_stack::report!(Error::Io) | ||
| .attach_printable(format!("Vendored gem path has no file name: {}", relative_path.display())) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the errors that are being converted to warnings (that are being silently ignored) are errors that should interrupt, like unparseable
package.ymland file read errors. The UI wasn't displaying the warnings or the errors, so they were just getting ignored. This is precedes #85 which was unable to produce any visible errors because errors from that part of the code were not configured to be printed in any UI.