node upgrade 14 to 20 #820
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Node.js runtime from version 14 to version 20, modernizing the frontend build and test infrastructure. The upgrade includes migrating from PhantomJS to headless Chrome for CI testing, updating dependency versions, and ensuring compatibility across Node.js 18, 20, and 22.
Key Changes:
- Upgraded Node.js from 14.x to 20.x (with minimum support for 18.x)
- Migrated CI testing from PhantomJS to headless Chrome with proper browser flags
- Updated pusher-js from v3.0.0 to v8.4.0 to support newer Node.js versions
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/.tool-versions | Updated Node.js version from 14.21.3 to 20.18.1 |
| frontend/package.json | Updated Node.js/npm engine requirements and upgraded pusher-js; removed phantomjs-prebuilt |
| frontend/testem.js | Migrated CI tests from PhantomJS to headless Chrome with appropriate browser arguments |
| frontend/config/environment.js | Added reCAPTCHA configuration override in test environment to prevent loading errors |
| .github/workflows/frontend.yml | Updated primary Node.js version to 20 and test matrix to support 18, 20, and 22; improved caching configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "node": ">=18.x", | ||
| "npm": ">=8.x" |
There was a problem hiding this comment.
The Node.js version constraint ">=18.x" may not work as intended. The .x suffix in semver ranges should not be used with comparison operators like >=. Consider using ">=18.0.0" or "^18.0.0 || ^20.0.0" instead for clearer version constraints. The same applies to the npm constraint ">=8.x".
| "node": ">=18.x", | |
| "npm": ">=8.x" | |
| "node": ">=18.0.0", | |
| "npm": ">=8.0.0" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.