Update to rails 5.0 #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 15, 2017 09:51
houndci-bot
reviewed
May 15, 2017
| (function() { | ||
| this.App || (this.App = {}); | ||
|
|
||
| App.cable = ActionCable.createConsumer(); |
There was a problem hiding this comment.
'App' is not defined.
'ActionCable' is not defined.
| //= require_tree ./channels | ||
|
|
||
| (function() { | ||
| this.App || (this.App = {}); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| @@ -0,0 +1,13 @@ | |||
| // Action Cable provides the framework to deal with WebSockets in Rails. | |||
| // You can generate new channels where WebSocket features live using the `rails generate channel` command. | |||
added 2 commits
May 15, 2017 11:10
This silences a deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates config files and default patterns for rails 5.0. Though this does include yarn support from 5.1
We are blocked moving fully to rails 5.1 over simple_form.