Tailwinds conversions #425

seanmarcia · 2025-09-13T18:10:18Z

WIP

dcollie2 · 2025-10-08T21:19:52Z

We'll want to get the tag and file management interfaces back in shape.

- Replace custom pagination with Pagy bootstrap helper and ensure search filter params persist across pages - Update search ordering to use published_at instead of created_at for topics - Fix password reset page link text expected by tests (Login) and restore test description text - Adjust Searcheable concern year/month scopes to handle blank params safely

…ect and ensure correct ordering for tests

- Ensure state filter respects enums in Searcheable#by_state - Force immediate form submission for month and state selects to avoid stale content in tests

We do not have a surver/privacy policy/terms of use and only registered users can log in, so I removed those links and the card that made it sound like anyone could sign up.

With the old design, we were filtering out archived topics by default.

Oli0li · 2025-11-10T18:17:02Z

I've resolved the conflicts/removed some unnecessary links, still need to fix:

pagination
tags
document upload interface
"Topic statistics" not aligned on Topic form
Background colour for rows on Region charts (hard to read until we hover on a row)
I think we can remove the capital letter on a purple background on the Topic list, it wasn't clear to me that this was the first letter of the Topic name, which led me to wonder if this was some kind of code

This was causing the content of the table to be displayed by default on a green background, making it hard to read.

It wasn't clear to me what it meant when I saw it. Since it is not some kind of code to help idenfity a certain category of topic, I think it is best to remove it to avoid confusion and leave more space for the title.

The choose_tag helper is no longer used so I removed it.

dmitrytrager · 2025-12-01T22:27:10Z

app/views/home/index.html.erb

+</footer>
+
+<style>
+  @keyframes fade-in-up {


Is it possible to load this as an asset?

dmitrytrager · 2025-12-01T22:30:01Z

app/helpers/pagination_helper.rb

+
+    content_tag :nav, 'aria-label': "Page navigation" do
+      content_tag :ul, class: "flex -space-x-px text-sm", style: "list-style: none; margin: 0; padding: 0;" do
+        safe_join([


Do we need this to connect page with tailwind?

dmitrytrager · 2025-12-01T22:32:06Z

app/views/languages/_form.html.erb

+    <%= render "shared/errors", errors: language.errors.full_messages, resource_name: language.class.name %>
+
+    <div style="margin-bottom: 1.5rem;">
+      <%= f.label :name, style: "display: block; font-size: 0.875rem; font-weight: 600; color: #374151; margin-bottom: 0.5rem;" do %>


Why do we use inline styles and not classes?

I agree, it would be a lot more readable and it would help ensure we have consistent stylings across the app

bin/dev

app/controllers/tags_controller.rb

dmitrytrager · 2025-12-04T22:43:45Z

app/views/layouts/home.html.erb

+      });
+
+      // Smooth scroll for anchor links
+      document.querySelectorAll('a[href^="#"]').forEach(anchor => {


I think this should live in JS module that we can load here

app/views/topics/edit.html.erb

config/routes.rb

Removing the ability to add new Tags from the Tag index was a conscious decision we took because we didn't want Tags that were not used on any Topics, and at the time it would not have been possible to determine for which language a Tag was meant. Now that we display all Tags regardless of a Topic's language, the language consideration would no longer be an issue, but the stakeholders haven't told us they needed this feature back. See the PR where we removed the ability to add Tags from the Tag index: 8f77030

This means we use overmind instead of foreman.

Users can already see this info on the form or when clicking on "View Topic Details" at the bottom of the form.

Red is generally displayed for destructive actions, but here we were displaying "Edit" in red and "Archive" in orange. Since we are using orange on the Edit forms elsewhere, I've used orange for the Edit button, gray for Archive, and red for Delete. But orange is also often used to indicate a mildly dangerous action, so I wonder if it should be changed to something less alarming, like blue, purple or green. But editing a Topic can indeed be slightly dangerous if the user makes a mistake, so it could also be argued that orange is appropriate.

I also removed the "Danger Zone" as I thought it was a bit confusing that it showed warnings for a Delete feature that does not exist. If the stakeholders need this feature, they will let us know and we can add it at that point.

Admins can already see that information on the form itself or by clicking on the "View Provider Details" button below.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Oli0li · 2025-12-06T17:56:50Z

I've asked Claude to help convert a lot of the repetitive inline styles into Tailwind classes, but there are still many files to cover.
On top of some of @dmitrytrager's comments I still need to address, I've also noted this should be changed:

Add spacing on Providers#show
For Providers forms, maybe use the same style we have to select several regions as we have on the User form

seanmarcia and others added 17 commits November 10, 2025 14:42

WIP

aba8f9b

wip

f34b00d

wip

d12793d

Wip

cfcb6ab

Wip

16b2189

wip

b777c5b

wip

316e8f4

wip

5d3475c

wip

e791089

Adjust topics search ordering and filter behavior; simplify order sel…

ccbde42

…ect and ensure correct ordering for tests

Fix remaining topic search state/month test failures

adaa276

- Ensure state filter respects enums in Searcheable#by_state - Force immediate form submission for month and state selects to avoid stale content in tests

Wip

1edb1aa

Remove unnecessary links

55d37a1

We do not have a surver/privacy policy/terms of use and only registered users can log in, so I removed those links and the card that made it sound like anyone could sign up.

Fix merge conflict

76c43a0

Fix upload management specs

3795fe7

Fix search spec expectations

a6811e4

With the old design, we were filtering out archived topics by default.

Oli0li force-pushed the tailwinds_conversions branch from 850fe0c to a6811e4 Compare November 10, 2025 18:03

Remove duplicate gem

1948d05

Oli0li added 4 commits November 17, 2025 17:06

Fix pagination

1b5061c

Fix missing closing div in Regions#index view

e9c5a4c

This was causing the content of the table to be displayed by default on a green background, making it hard to read.

Remove purple letter on Topic list

572389f

It wasn't clear to me what it meant when I saw it. Since it is not some kind of code to help idenfity a certain category of topic, I think it is best to remove it to avoid confusion and leave more space for the title.

Fix alignement on Topic form

51e7536

Oli0li force-pushed the tailwinds_conversions branch from 82f5572 to 5afd19b Compare November 18, 2025 19:07

Oli0li added 4 commits November 20, 2025 22:04

Merge main

c610c22

Fix broken svgs

d18ea15

Fix Topic form loading button logic

db90cd7

Style file upload interface

e5411cf

Oli0li added 6 commits November 29, 2025 19:42

Fix topics/search spec

1d21809

The choose_tag helper is no longer used so I removed it.

Fix upload_management_spec

1623a8e

Fix pagination tests

e2822d4

Fix tag update spec

a3db405

Fix CI issue not finding tailwind.css

9059a44

Fix Tags#show page

ef035af

Oli0li force-pushed the tailwinds_conversions branch from 65481bf to ef035af Compare November 29, 2025 19:45

Oli0li requested review from dcollie2 and dmitrytrager November 29, 2025 19:48

dmitrytrager reviewed Dec 1, 2025

View reviewed changes

app/views/home/index.html.erb

</footer>

<style>

@keyframes fade-in-up {

Copy link

Collaborator

dmitrytrager Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to load this as an asset?

dmitrytrager reviewed Dec 1, 2025

View reviewed changes

bin/dev Outdated Show resolved Hide resolved

dmitrytrager reviewed Dec 1, 2025

View reviewed changes

app/controllers/tags_controller.rb Outdated Show resolved Hide resolved

dmitrytrager reviewed Dec 4, 2025

View reviewed changes

app/views/topics/edit.html.erb Outdated Show resolved Hide resolved

dmitrytrager reviewed Dec 4, 2025

View reviewed changes

config/routes.rb Outdated Show resolved Hide resolved

Oli0li added 10 commits December 6, 2025 15:33

Merge branch 'main' into tailwinds_conversions

c8c2731

Restore bin/dev to previous state

ae17a96

This means we use overmind instead of foreman.

Remove redundant information on Topic edit form

fb58770

Users can already see this info on the form or when clicking on "View Topic Details" at the bottom of the form.

Use Tailwind classes on Topics#index

3c9b31e

Use Tailwind classes on Language#edit form

e3acda8

I also removed the "Danger Zone" as I thought it was a bit confusing that it showed warnings for a Delete feature that does not exist. If the stakeholders need this feature, they will let us know and we can add it at that point.

Use Tailwind classes on Languages#index

79a06dc

Use classes for gradient styles

c139d46

Remove unnecessary info on Providers#edit

57e46fb

Admins can already see that information on the form itself or by clicking on the "View Provider Details" button below.

Copilot AI review requested due to automatic review settings December 6, 2025 17:56

Copilot AI reviewed Dec 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tailwinds conversions #425

Tailwinds conversions #425

Uh oh!

seanmarcia commented Sep 13, 2025

Uh oh!

dcollie2 commented Oct 8, 2025

Uh oh!

Oli0li commented Nov 10, 2025 •

edited

Loading

Uh oh!

dmitrytrager Dec 1, 2025

Uh oh!

dmitrytrager Dec 1, 2025

Uh oh!

dmitrytrager Dec 1, 2025

Uh oh!

Oli0li Dec 6, 2025

Uh oh!

Uh oh!

Uh oh!

dmitrytrager Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Oli0li commented Dec 6, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Tailwinds conversions #425

Are you sure you want to change the base?

Tailwinds conversions #425

Uh oh!

Conversation

seanmarcia commented Sep 13, 2025

Uh oh!

dcollie2 commented Oct 8, 2025

Uh oh!

Oli0li commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmitrytrager Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

dmitrytrager Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

dmitrytrager Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Oli0li Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dmitrytrager Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Oli0li commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Oli0li commented Nov 10, 2025 •

edited

Loading

Oli0li commented Dec 6, 2025 •

edited

Loading