fix: Have to build the gem before we can find it, doh#13
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a timing issue in the gem publishing script where the gem file lookup was happening before the gem was actually built, causing publishing to fail. The fix moves the bundle exec gem build command earlier in the script and adjusts file path references to use a consistent root directory variable.
- Moves gem build command before gem file lookup to ensure the gem exists when searching for it
- Introduces a
rootvariable for consistent path resolution - Updates gem file path construction to use the new root variable instead of relative paths
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasn't building the gem before looking for it to publish,
so the publishing never happened. This moves the build
earlier than the lookup. Tested locally.