Show automatic search feedback in Activity tab (#597)#631
Show automatic search feedback in Activity tab (#597)#631joptimus wants to merge 21 commits intoruddarr:developfrom
Conversation
|
This is very AI sloppy TBH and Ruddarr is written by hand, that's why it's nice. But first let me understand what you're trying to see in Ruddarr. Can you please post a video of how you see recent searches in Radarr/Sonarr right now? Like what feature you're trying to replicate. |
|
@tillkruss this follows what I posted in #597 (comment), where I described the approach I was going to take by putting the command feedback in Activity. I know the OP never posted a screenshot of what they were asking for but here is what i think he was asking for (and what I was looking for myself)
The search in the queue is what I brought into Rudarr just kept in within the exisiting Activity flow. If you want me to adjust anything once youve had a chance to look at the code just let me know. |
|
@joptimus That's helpful. I see that after the episode search is done, the task disappears and it will show the result in |
|
@tillkruss yes thats correct. I didnt want to persist it without talking to you first as I figured to just do this PR and then discuss it. Same with another idea of having the total count listed in tab as a badge versus showing as |
|
@joptimus Got it, so you just want to see currently running tasks? I think we could fetch them and add them to That said, it only refreshes every 5 seconds and the task might have disappeared by then. Maybe the history view needs to be more prominent? |
|
@tillkruss for me what I'm trying to solve and I think where the OPs request came from is that currently as a user you initiate a search and all you see is a toast. If you go to Activity theres nothing that shows your server is actually searching or acknowledged the task. I think we are saying the same thing but what you are picturing as a small PR only covers the data fetching side it doesn't solve the UI. Once you put the UI in and make it functional, I think you end up right at my PR. Take a look when you get a chance and let me know what you think! |
|
I think something like this is nicer. Just a mockup but literally a fraction the size of this PR. Any feedback welcome of course.
|
|
@tillkruss I looked at yours and that's the same data layer I have. The difference is mine actually solves the problem end to end. You get a detail sheet on tap, dispatch tracking so searches that finish in under 5 seconds don't get lost, session history so completed commands stick around while you're using the app. Your version would have the problem you called out of refreshing every 5 seconds and the task might have disappeared by then. I see you dont like the segment tabs so I've reworked mine based on your example by dropping the separate tab and cleaned up the code
|
The core issue you're having is that you want feedback for automatic searches right? Can you explain this in detail to me?
|
I believe my PR already covers all of this plus dispatch tracking so fast searches dont get lost between polls. Can you take a look and give me any feedback? |
|
Okay, final questions. Right now when you hit automatic search *arrs will display a little overlay in the bottom left corner (which Ruddarr doesn't do). What do you see/do if a search fails? Do you sit there and wait for it to complete and then go check something? |
|
@tillkruss Usually I tap automatic search then flip to Activity to see if its doing anything. Right now theres nothing there so I end up waiting 30 seconds and then running a manual search just to see what happened. If the search failed I'd have no idea unless I go dig through History. So yeah I do sit there wondering, which is exactly the problem. |
|
I feel like Radarr/Sonarr need to solve this, not Ruddarr, unless either is doing something already that Ruddarr isn't? |
|
@tillkruss Honestly Im not sure whats left to answer here. The questions in your last comment are ones Ive already answered earlier in this thread and the functionality your asking about is in the PR. The dispatch tracking, failure visibility, the detail sheet are all there and demoed in the screenshots above. I stripped the segmented tab and reworked the UI based on your feedback in good faith because I wanted to ship something useful for users. If there are specific gaps or concerns about this PR you want me to look at Im more than happy to take another pass at it. Otherwise let me know if its ready for a full review or if you prefer I close it. |




Adds a Searches section to Activity so users can see the result of automatic searches, similar to Radarr/Sonarr's command history.
Search commands show live status, result message, and timestamps. Tapping a row opens a detail sheet. Follows the same patterns as the existing Queue/QueueItemSheet.
Closes #597
demo.mp4