Skip to content

Don't offset content when Reduce Transparency is enabled #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tillkruss merged 7 commits into from
Apr 8, 2026
+11 −22
Merged

Don't offset content when Reduce Transparency is enabled #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
74b90ce
Skip negative top padding when Reduce Transparency is enabled
claude Apr 8, 2026
7d43004
Apply same Reduce Transparency fix to remaining sheets and forms
claude Apr 8, 2026
7999bc9
consolidate lines
tillkruss Apr 8, 2026
146ba21
drop
tillkruss Apr 8, 2026
85b7c53
revert
tillkruss Apr 8, 2026
b3d1925
revert
tillkruss Apr 8, 2026
054f2c9
revert
tillkruss Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Ruddarr/Views/Activity/QueueItemSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ struct QueueItemSheet: View {
@Environment(\.dismiss) private var dismiss
@Environment(\.openURL) private var openURL
@Environment(\.deviceType) private var deviceType
@Environment(\.accessibilityReduceTransparency) private var reduceTransparency

@State private var downloadProgress: Float = 0

let timer = Timer.publish(every: 1, on: .main, in: .common).autoconnect()

var body: some View {
// swiftlint:disable:next closure_body_length
NavigationStack {
ScrollView {
VStack(alignment: .leading) {
Expand Down Expand Up @@ -47,11 +47,7 @@ struct QueueItemSheet: View {
details
}
.scenePadding(.horizontal)
#if os(macOS)
.padding(.top, 24)
#else
.offset(y: -45)
#endif
.padding(.top, deviceType == .mac ? 24 : (reduceTransparency ? 0 : -45))
}
.toolbar {
ToolbarItem(placement: .destructiveAction) {
Expand Down
7 changes: 2 additions & 5 deletions Ruddarr/Views/Movies/Releases/MovieReleaseSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ struct MovieReleaseSheet: View {

@Environment(\.dismiss) private var dismiss
@Environment(\.deviceType) private var deviceType
@Environment(\.accessibilityReduceTransparency) private var reduceTransparency

@State private var showGrabConfirmation: Bool = false

Expand All @@ -32,11 +33,7 @@ struct MovieReleaseSheet: View {
details
}
.scenePadding(.horizontal)
#if os(macOS)
.padding(.top, 24)
#else
.padding(.top, -45)
#endif
.padding(.top, deviceType == .mac ? 24 : (reduceTransparency ? 0 : -45))
}
.toolbar {
ToolbarItem(placement: .destructiveAction) {
Expand Down
7 changes: 2 additions & 5 deletions Ruddarr/Views/Series/Releases/SeriesReleaseSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ struct SeriesReleaseSheet: View {

@Environment(\.dismiss) private var dismiss
@Environment(\.deviceType) private var deviceType
@Environment(\.accessibilityReduceTransparency) private var reduceTransparency

@State private var showGrabConfirmation: Bool = false

Expand All @@ -34,11 +35,7 @@ struct SeriesReleaseSheet: View {
details
}
.scenePadding(.horizontal)
#if os(macOS)
.padding(.top, 24)
#else
.padding(.top, -45)
#endif
.padding(.top, deviceType == .mac ? 24 : (reduceTransparency ? 0 : -45))
}
.toolbar {
ToolbarItem(placement: .destructiveAction) {
Expand Down
8 changes: 3 additions & 5 deletions Ruddarr/Views/Shared/MediaEventSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ struct MediaEventSheet: View {
@EnvironmentObject var settings: AppSettings

@Environment(\.dismiss) private var dismiss
@Environment(\.deviceType) private var deviceType
@Environment(\.accessibilityReduceTransparency) private var reduceTransparency

var body: some View {
// swiftlint:disable:next closure_body_length
Expand Down Expand Up @@ -50,11 +52,7 @@ struct MediaEventSheet: View {
Spacer()
}
.scenePadding(.horizontal)
#if os(macOS)
.padding(.top, 24)
#else
.offset(y: -45)
#endif
.padding(.top, deviceType == .mac ? 24 : (reduceTransparency ? 0 : -45))
}
.toolbar {
ToolbarItem(placement: .destructiveAction) {
Expand Down
3 changes: 2 additions & 1 deletion Ruddarr/Views/Shared/MediaFileSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ struct MediaFileSheet: View {
var runtime: Int

@Environment(\.dismiss) private var dismiss
@Environment(\.accessibilityReduceTransparency) private var reduceTransparency

var body: some View {
NavigationStack {
Expand All @@ -17,7 +18,7 @@ struct MediaFileSheet: View {

Spacer().frame(height: 42)
}
.padding(.top, -52)
.padding(.top, reduceTransparency ? 0 : -52)
.scenePadding(.horizontal)
}
#if os(macOS)
Expand Down
Loading