Skip to content

ql-https.lisp ~ rewrite verify-download to be a CLOS :after method #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rudolfochrist merged 1 commit into from
Feb 25, 2026
Merged

ql-https.lisp ~ rewrite verify-download to be a CLOS :after method #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ql-https.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@
:error-output :output))
(file (and file (probe-file file)))
(release (url-to-release url)))
(when release
(verify-download file release))
(values output file))
(restart-case
(handler-bind ((no-https-error (lambda (c)
Expand Down Expand Up @@ -92,14 +90,15 @@
(with-open-file (f file)
(file-length f)))

(defun verify-download (file name)
(defmethod ql-dist:check-local-archive-file :after ((release ql-dist:release))
"Checks that the md5 and size of FILE are as expected from the quicklisp
dist."
(let ((release (ql-dist:find-release name)))
(unless (= (ql-dist:archive-size release) (file-size file))
(error "file size mismatch for ~A" name))
(let ((name (ql-dist:name release))
(file (ql-dist:local-archive-file release)))

(unless (string-equal (ql-dist:archive-md5 release) (md5 file))
(error "md5 mismatch for ~A" name))

(unless (member (ql-dist:archive-content-sha1 release)
(list (content-hash file (lambda (c) (sort c #'string< :key #'first)))
(content-hash file #'reverse))
Expand Down