Terry/qa template #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlyjak
reviewed
Sep 18, 2025
| LLAMA_CLOUD_PROJECT_ID, | ||
| ) | ||
|
|
||
| load_dotenv() |
There was a problem hiding this comment.
what's this for? Doesn't really hurt, but this is automatically handled by llama deploy
[tool.llamadeploy]
env-files = [".env"]
There was a problem hiding this comment.
OPENAI_API_KEY somehow not able to be passed. That's why I add it back
There was a problem hiding this comment.
Seems found the root cause? Now we only read env_files, but config here is env-files
adrianlyjak
reviewed
Sep 18, 2025
| return { | ||
| file_id: files[0].fileId, | ||
| index_name: fieldValues.index_name, | ||
| index_name: INDEX_NAME, |
There was a problem hiding this comment.
shouldn't this just entirely be managed on the server? I don't see a reason it needs to be parameterized
There was a problem hiding this comment.
Just want to be as less change as possible to ship...
adrianlyjak
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.