Merged
Conversation
Use the Card asChild prop to make the entire card a Link element, improving UX by allowing users to click anywhere on the card instead of just the 'Learn More' text.
There was a problem hiding this comment.
Pull request overview
This PR enhances the product card component's user experience by making the entire card clickable instead of just the "Learn More" link. The implementation uses the Card component's asChild prop to transform it into a Link element, improving accessibility with an aria-label attribute.
Key Changes
- Made entire product card clickable by wrapping content in a Link component using Card's
asChildprop - Added accessibility label describing the card's purpose
- Converted "Learn More" from an interactive link to a visual indicator
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/products/ProductCard/ProductCard.tsx | Restructured Card component to use asChild with Link wrapper, added aria-label, converted Learn More to non-interactive span |
| src/components/products/ProductCard/ProductCard.test.tsx | Updated test to verify entire card is clickable and check for new aria-label |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
vibes-website | 22872ef | Commit Preview URL Branch Preview URL |
Dec 27 2025, 10:38 PM |
- Remove aria-label to let screen readers announce card content naturally - Add group hover state to 'Learn More →' for visual feedback on card hover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asChildprop to make the entire card a Link elementaria-labelfor accessibility ("Learn more about {name}")Test Plan
pnpm test)pnpm typecheck && pnpm lint)