Skip to content

fix: align list item bullets with text on products page#30

Merged
rupurt merged 1 commit intomainfrom
product-list-items-alignment
Dec 28, 2025
Merged

fix: align list item bullets with text on products page#30
rupurt merged 1 commit intomainfrom
product-list-items-alignment

Conversation

@rupurt
Copy link
Copy Markdown
Contributor

@rupurt rupurt commented Dec 28, 2025

Summary

  • Fix bullet point alignment in ProductCard feature lists
  • Increase margin-top from mt-0.5 to mt-1 to match text-sm line-height

Test Plan

  • Unit tests passing (pnpm test)
  • TypeScript and lint checks pass
  • Visual verification on /products page

Copilot AI review requested due to automatic review settings December 28, 2025 00:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the vertical alignment of bullet points in product feature lists by adjusting the top margin of the bullet span element to better match the line height of the accompanying text.

Key Changes:

  • Adjusted bullet point vertical positioning in ProductCard component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Dec 28, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
vibes-website a2e3664 Commit Preview URL

Branch Preview URL
Dec 28 2025, 12:18 AM

Use items-baseline instead of items-start to properly align the
bullet character with the text baseline, regardless of font size.
@rupurt rupurt force-pushed the product-list-items-alignment branch from 74cd6b0 to a2e3664 Compare December 28, 2025 00:17
@rupurt rupurt merged commit c15dad0 into main Dec 28, 2025
3 checks passed
@rupurt rupurt deleted the product-list-items-alignment branch December 28, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants