Skip to content

fix: improve vibes page mobile layout #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rupurt merged 1 commit into from
Dec 28, 2025
Merged

fix: improve vibes page mobile layout #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/products/CodeBlock/CodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function CodeBlock({ code, className }: CodeBlockProps) {
return (
<div
className={cn(
'relative flex items-center gap-3 rounded-lg bg-muted/50 border border-border px-4 py-3 font-mono text-sm',
'relative flex items-center gap-3 rounded-lg bg-muted/50 border border-border px-4 py-3 font-mono text-xs sm:text-sm',
className,
)}
>
Expand Down
9 changes: 7 additions & 2 deletions src/routes/products/vibes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function VibesPage() {
</div>

<div className="flex items-center justify-center gap-4">
<Button asChild size="lg">
<Button asChild size="lg" className="h-10 px-5 text-sm sm:h-12 sm:px-7 sm:text-base">
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The className prop overrides the size='lg' prop's built-in styling. Consider removing the size prop or creating a custom size variant instead of using className overrides, as this pattern can lead to confusion and maintenance issues when the Button component's size definitions change.

Copilot uses AI. Check for mistakes.
<a
href="https://github.com/run-vibes/vibes"
target="_blank"
Expand All @@ -62,7 +62,12 @@ function VibesPage() {
Star on GitHub
</a>
</Button>
<Button variant="outline" asChild size="lg">
<Button
variant="outline"
asChild
size="lg"
className="h-10 px-5 text-sm sm:h-12 sm:px-7 sm:text-base"
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the same responsive styling from the button above. Consider extracting these classes into a shared constant (e.g., const responsiveButtonClasses = 'h-10 px-5 text-sm sm:h-12 sm:px-7 sm:text-base') to maintain consistency and reduce duplication.

Copilot uses AI. Check for mistakes.
>
<a
href="https://github.com/run-vibes/vibes#readme"
target="_blank"
Expand Down
Loading