Skip to content

Add option for resources limits#167

Open
caputchinefrobles wants to merge 1 commit intorundeck-plugins:masterfrom
caputchinefrobles:add-container-limits
Open

Add option for resources limits#167
caputchinefrobles wants to merge 1 commit intorundeck-plugins:masterfrom
caputchinefrobles:add-container-limits

Conversation

@caputchinefrobles
Copy link
Copy Markdown

Adds the possibility to set container resource limits (jobs, deployments and pods).

@fdevans
Copy link
Copy Markdown
Contributor

fdevans commented Mar 6, 2026

Thank you for this contribution! This is a well-implemented feature that adds resource limits support to complement the existing resource requests functionality.

What we like:

  • Focused on a single, clear use case
  • Follows the existing pattern for resources_requests consistently
  • Non-breaking change (purely additive)
  • Covers all relevant workflow steps (jobs, deployments, pods)

Before we can merge, we need:

  1. Rebase on the latest master branch - This PR is from 2023 and there have been significant changes since then. Please rebase to ensure compatibility.

  2. Documentation - Please add a section to the README explaining:

    • How to use resources_limits
    • The format (e.g., cpu=4,memory=1Gi)
    • An example showing both requests and limits together
    • Link to Kubernetes documentation on resource limits
  3. Consider adding validation (optional) - While the existing resources_requests doesn't validate input either, it might be worth adding basic format validation to catch configuration errors early. This is optional and could be a separate PR.

Once you rebase and add documentation, we'd be happy to merge this!

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants