reorder volume and volume_mounts parameter#168
reorder volume and volume_mounts parameter#168remenaker wants to merge 1 commit intorundeck-plugins:masterfrom
Conversation
|
Thank you for identifying this inconsistency! You're absolutely right that having different parameter ordering between Pod/Create and Job/Create steps causes confusion when copying configurations. However, we'd like to suggest the opposite fix. Your PR makes Job/Create match Pod/Create by putting In Kubernetes:
Current state:
Recommendation:
Would you be willing to update this PR to fix Pod/Create instead, making it match Job/Create's ordering? That would put Also, please rebase on the latest master branch before updating. Thanks for catching this inconsistency! |
This PR is to fix the order of the Volume and Volume Mounts parameters. We had an issue in were options were copied from the Pod/Create workflow step to the Job/Create workflow step. When copying the options from one to another it went un-noticed that the volumes and volume_mounts were switched between the steps, thus volumes were not created correctly. It took some time to notice this and correct it. Hopefully this will save some others headache in the future. Thanks!