fix: command arguments need to be split#169
fix: command arguments need to be split#169neuromantik33 wants to merge 1 commit intorundeck-plugins:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the pod script execution where command arguments were being passed as a single string instead of being split into individual arguments. This ensures that inline scripts in pods receive properly formatted command-line arguments.
- Splits the RD_CONFIG_ARGUMENTS string into individual arguments using spaces as delimiters
- Changes from appending a single string to appending individual arguments to the exec_command list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if 'RD_CONFIG_ARGUMENTS' in os.environ: | ||
| arguments = os.environ.get('RD_CONFIG_ARGUMENTS') | ||
| exec_command.append(arguments) | ||
| for arg in arguments.split(" "): |
There was a problem hiding this comment.
Using split(' ') will not handle arguments that contain spaces (even when quoted) or multiple consecutive spaces correctly. Consider using shlex.split() instead, which properly handles shell-style quoting and escaping.
|
Thank you for identifying this bug! You're absolutely right that arguments need to be split - the current code incorrectly passes all arguments as a single string element instead of splitting them into individual arguments. Your fix is correct and consistent with how the code already handles the One consideration: Simple space-splitting doesn't handle quoted arguments (e.g., Before we can merge this, could you please:
Thanks for the contribution! |
Command arguments need to be split when invoking inline scripts in pods.