Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 80.63% 80.71% +0.08%
==========================================
Files 46 46
Lines 3511 3495 -16
==========================================
- Hits 2831 2821 -10
+ Misses 680 674 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pratduv
force-pushed
the
prat/fix
branch
2 times, most recently
from
436c772 to
6f29896
Compare
pratduv
commented
Aug 7, 2025
| RequestMethod.POST, endpoint=Routes.traces.format(project_id=self.project_id), json=json | ||
| ) | ||
|
|
||
| async def ingest_spans(self, spans_ingest_request: SpansIngestRequest) -> dict[str, str]: |
Contributor
Author
There was a problem hiding this comment.
I want to do what I did with ingest_traces to all other functions in this file. Do we really need both _make_request and _make_async_requestwhen under the hood request callsasync_runin the end (viagalileo-core`? We have a lot of logic duplication in this file
pratduv
commented
Aug 7, 2025
| name=name, previous_session_id=previous_session_id, external_id=external_id | ||
| ) | ||
|
|
||
| async def async_start_session( |
Contributor
Author
There was a problem hiding this comment.
ignore this change for now
pratduv
force-pushed
the
prat/fix
branch
2 times, most recently
from
8b14cef to
bf88d78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: rn we have logic for
flush(),update_trace/step_streaming()etc that calls a sync/async function in core_api_client.py that has the same logic duplicated across the sync/async functionsDepending on whether it's a sync or async function, we then call
galileo-core api_client.pyrequest()orarequest().. but both eventually use the sameApiClient.make_requestcallI think this balloons that file up for no reason (unless I'm missing something important) and we should have async_run used instead at the logger.py level.