Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 84.90% 83.80% -1.11%
==========================================
Files 9 9
Lines 921 926 +5
==========================================
- Hits 782 776 -6
- Misses 139 150 +11
Continue to review full report at Codecov.
|
calvogenerico
commented
Aug 9, 2021
|
|
||
| _onAddTransaction (txid) { | ||
| this.logger.info('Added', txid) | ||
| this.logger.debug('Added', txid) |
Contributor
Author
There was a problem hiding this comment.
The logs are impossible to interprete with the wall of "Added txid". I believe this should be considered debug information. If an specifc txid has to be requested it's easier just do a query.
|
|
||
| async getRawBlockByHash (targetHash) { | ||
| const response = await fetch(`${this.baseUrl}/rest/block/${targetHash}.bin`) | ||
| return Buffer.from(await response.arrayBuffer()) |
Contributor
Author
There was a problem hiding this comment.
With this blocks are always just a buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using bsv's rest api we avoid all the issues related to block size and json/string/js limits becase we can directly interpret everything as a buffer.