Розширення Функціоналу Django Rest Framework

hr/api_views.py

@@ -11,7 +11,7 @@
     Position,
 )
 from hr.pagination import SmallSetPagination
-from hr.permissions import IsNotRussianEmail
+from hr.permissions import IsNotRussianEmail, EmployeePermission
 from hr.pydantic_models import WorkingDays
 from hr.serializers import (
     EmployeeSerializer,
@@ -27,7 +27,7 @@ class EmployeeViewSet(viewsets.ModelViewSet):
     queryset = Employee.objects.all().order_by()
     serializer_class = EmployeeSerializer
     pagination_class = SmallSetPagination
-    permission_classes = [IsNotRussianEmail]
+    permission_classes = [IsNotRussianEmail, EmployeePermission]
 
     def get_queryset(self):
         queryset = super().get_queryset()

hr/permissions.py

@@ -10,3 +10,7 @@ def has_permission(self, request, view):
         if request.user and request.user.email:
             return not request.user.email.endswith('.ru')
         return False
+
+class EmployeePermission(permissions.BasePermission):
+    def has_object_permission(self, request, view, obj):
+        return obj.position is not None

hr/serializers.py

@@ -4,7 +4,7 @@
     Employee,
     Position,
 )
-from hr.validators import validate_positive
+from hr.validators import validate_positive, validate_holiday_days
 
 
 class EmployeeSerializer(serializers.ModelSerializer):
@@ -21,8 +21,8 @@ class Meta:
 
 class SalarySerializer(serializers.Serializer):
     employee = serializers.PrimaryKeyRelatedField(queryset=Employee.objects.all())
-    working_days = serializers.IntegerField(validators=[validate_positive])
-    holiday_days = serializers.IntegerField()
+    working_days = serializers.IntegerField(validators=[validate_positive], max_value=31)
+    holiday_days = serializers.IntegerField(validators=[validate_holiday_days])
     sick_days = serializers.IntegerField(default=0, max_value=4)
     vacation_days = serializers.IntegerField(default=0)
 
@@ -44,3 +44,8 @@ def validate_sick_days(self, value):
         if value > 3:
             raise serializers.ValidationError('The number of sick days cannot be more than 3.')
         return value
+
+    def validate_vacation_days(self, value):
+        if value > 5:
+            raise serializers.ValidationError('The number of vacation days cannot be more than 5.')
+        return value

hr/validators.py

@@ -4,3 +4,7 @@
 def validate_positive(value):
     if value < 0:
         raise serializers.ValidationError('This field must be positive.')
+
+def validate_holiday_days(value):
+    if value > 10:
+        raise serializers.ValidationError('This field must be between 1 and 10.')

poetry.toml

@@ -0,0 +1,2 @@
+[virtualenvs]
+in-project = true