added validation vacation_days and working_days also added custom val…

README.md

@@ -0,0 +1,5 @@
+# Django Rest Framework
+* Validate vacation_days
+* Validate working_days
+* Custom validate holiday_days
+* Custom Permission for EmployeeViewSet

hr/mixins.py

@@ -1,6 +1,16 @@
 from django.contrib.auth.mixins import UserPassesTestMixin
+from django.core.exceptions import PermissionDenied
 
 
 class UserIsAdminMixin(UserPassesTestMixin):
     def test_func(self):
         return self.request.user.is_superuser
+
+class EmployeeHasPositionMixin:
+    def dispatch(self, request, *args, **kwargs):
+        obj = self.get_object()
+
+        if not obj.position:
+            raise PermissionDenied("Employee don't have position.")
+
+        return super().dispatch(request, *args, **kwargs)

hr/permissions.py

@@ -10,3 +10,7 @@ def has_permission(self, request, view):
         if request.user and request.user.email:
             return not request.user.email.endswith('.ru')
         return False
+
+class HasPositionPermission(permissions.BasePermission):
+    def has_object_permission(self, request, view, obj):
+        return bool(obj.position)

hr/serializers.py

@@ -4,7 +4,7 @@
     Employee,
     Position,
 )
-from hr.validators import validate_positive
+from hr.validators import validate_positive, validate_holiday_days
 
 
 class EmployeeSerializer(serializers.ModelSerializer):
@@ -21,8 +21,8 @@ class Meta:
 
 class SalarySerializer(serializers.Serializer):
     employee = serializers.PrimaryKeyRelatedField(queryset=Employee.objects.all())
-    working_days = serializers.IntegerField(validators=[validate_positive])
-    holiday_days = serializers.IntegerField()
+    working_days = serializers.IntegerField(validators=[validate_positive], max_value=31)
+    holiday_days = serializers.IntegerField(validators=[validate_holiday_days])
     sick_days = serializers.IntegerField(default=0, max_value=4)
     vacation_days = serializers.IntegerField(default=0)
 
@@ -44,3 +44,11 @@ def validate_sick_days(self, value):
         if value > 3:
             raise serializers.ValidationError('The number of sick days cannot be more than 3.')
         return value
+
+    def validate_vacation_days(self, value):
+        if value > 5:
+            raise serializers.ValidationError('The number of vocation days cannot be more than 5.')
+
+        return value
+
+

hr/validators.py

@@ -4,3 +4,9 @@
 def validate_positive(value):
     if value < 0:
         raise serializers.ValidationError('This field must be positive.')
+
+def validate_holiday_days(value):
+    if value > 10:
+        raise serializers.ValidationError("The number of holiday days cannot be more than 10.")
+
+    return value

hr/views/generic_views.py

@@ -20,7 +20,7 @@
     EmployeeForm,
     SalaryForm,
 )
-from hr.mixins import UserIsAdminMixin
+from hr.mixins import UserIsAdminMixin, EmployeeHasPositionMixin
 from hr.models import Employee
 
 
@@ -72,7 +72,7 @@ class EmployeeDeleteView(UserIsAdminMixin, DeleteView):
     success_url = reverse_lazy('hr:employee_list')
 
 
-class EmployeeProfileView(UserIsAdminMixin, DetailView):
+class EmployeeProfileView(UserIsAdminMixin, EmployeeHasPositionMixin, DetailView):
     model = Employee
     template_name = 'employee_profile.html'