added tests for Views and PositionViewSet

README.md

@@ -0,0 +1,3 @@
+# Django tests
+1. Tests for Views
+2. Tests for PositionViewSet

hr/tests/test_employees.py

@@ -11,7 +11,6 @@
     PositionFactory,
 )
 
-
 class EmployeeListViewTest(TestCase):
     def setUp(self):
         self.client = Client()
@@ -20,24 +19,20 @@ def setUp(self):
         self.url = reverse('hr:employee_list')
 
     def test_access_employee_list(self):
-        # response = self.client.get(self.url)
         response = self.client.get(self.url)
         self.assertEqual(response.status_code, 200)
 
     def test_employee_list_content(self):
-        # response = self.client.get(self.url, )
         response = self.client.get(self.url )
         self.assertTrue('employees' in response.context)
         self.assertEqual(len(response.context['employees']), 10)
 
     def test_employee_search(self):
         search_query = self.employees[0].first_name
-        # response = self.client.get(f'{self.url}?search={search_query}')
         response = self.client.get(f'{self.url}?search={search_query}')
         self.assertTrue(len(response.context['employees']), 1)
         self.assertEqual(response.context['employees'][0].first_name, search_query)
 
-
 class EmployeeCreateViewTest(TestCase):
     def setUp(self):
         self.client = Client()
@@ -57,7 +52,6 @@ def test_successful_employee_creation(self):
             'email': 'johndoe@example.com',
             'position': self.position.id,
         }
-        # response = self.client.post(self.url, employee_data)
         response = self.client.post(self.url, employee_data)
         self.assertEqual(response.status_code, 302)
         self.assertTrue(Employee.objects.filter(username=username).exists())
@@ -73,7 +67,6 @@ def test_create_employee_by_non_admin(self):
             'position': self.position.id,
         }
         response = self.client.post(self.url, employee_data)
-        # response = self.client.post(self.url, employee_data)
         self.assertNotEqual(response.status_code, 302)
         self.assertFalse(Employee.objects.filter(username=username).exists())
 
@@ -87,9 +80,77 @@ def test_successful_employee_creation_message(self):
             'email': 'johndoe@example.com',
             'position': self.position.id,
         }
-        # response = self.client.post(self.url, employee_data)
         response = self.client.post(self.url, employee_data)
         messages = list(get_messages(response.wsgi_request))
         self.assertEqual(len(messages), 1)
         self.assertEqual(str(messages[0]), 'Працівника успішно створено.')
 
+class EmployeeProfileViewTest(TestCase):
+    def setUp(self):
+        self.client = Client()
+        self.admin_user = EmployeeFactory(is_staff=True, is_superuser=True)
+        self.employee = EmployeeFactory()
+        self.url = reverse('hr:employee_profile', args=[self.employee.pk])
+
+    def test_profile_view_by_admin(self):
+        self.client.force_login(self.admin_user)
+        response = self.client.get(self.url)
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(response, self.employee.first_name)
+        self.assertContains(response, self.employee.last_name)
+
+class EmployeeUpdateViewTest(TestCase):
+    def setUp(self):
+        self.client = Client()
+        self.admin_user = EmployeeFactory(is_staff=True, is_superuser=True)
+        self.employee = EmployeeFactory(first_name='OldName')
+        self.url = reverse('hr:employee_update', args=[self.employee.pk])
+
+    def test_successful_employee_update(self):
+        self.client.force_login(self.admin_user)
+        updated_data = {
+            'username': self.employee.username,
+            'first_name': 'NewName',
+            'last_name': self.employee.last_name,
+            'email': self.employee.email,
+            'position': PositionFactory().id,
+        }
+        response = self.client.post(self.url, updated_data)
+        self.assertEqual(response.status_code, 302)
+        self.employee.refresh_from_db()
+        self.assertEqual(self.employee.first_name, 'NewName')
+
+    def test_update_employee_by_non_admin(self):
+        non_admin = EmployeeFactory(is_staff=False, is_superuser=False)
+        self.client.force_login(non_admin)
+        updated_data = {
+            'username': self.employee.username,
+            'first_name': 'NewName',
+            'last_name': self.employee.last_name,
+            'email': self.employee.email,
+            'position': PositionFactory().id,
+        }
+        response = self.client.post(self.url, updated_data)
+        self.assertNotEqual(response.status_code, 302)
+        self.employee.refresh_from_db()
+        self.assertEqual(self.employee.first_name, 'OldName')
+
+class EmployeeDeleteViewTest(TestCase):
+    def setUp(self):
+        self.client = Client()
+        self.admin_user = EmployeeFactory(is_staff=True, is_superuser=True)
+        self.employee_to_delete = EmployeeFactory()
+        self.url = reverse('hr:employee_delete', args=[self.employee_to_delete.pk])
+
+    def test_successful_employee_delete(self):
+        self.client.force_login(self.admin_user)
+        response = self.client.post(self.url)
+        self.assertEqual(response.status_code, 302)
+        self.assertFalse(Employee.objects.filter(pk=self.employee_to_delete.pk).exists())
+
+    def test_delete_employee_by_non_admin(self):
+        non_admin = EmployeeFactory(is_staff=False, is_superuser=False)
+        self.client.force_login(non_admin)
+        response = self.client.post(self.url)
+        self.assertNotEqual(response.status_code, 302)
+        self.assertTrue(Employee.objects.filter(pk=self.employee_to_delete.pk).exists())

hr/tests/test_employees_api.py

@@ -9,6 +9,7 @@
 from hr.tests.factories import (
     EmployeeFactory,
     PositionFactory,
+    DepartmentFactory,
 )
 
 
@@ -49,3 +50,49 @@ def test_search_employee(self):
         response = self.client.get(reverse('api-hr:employee-list'), {'search': 'Test'})
         self.assertEqual(response.status_code, status.HTTP_200_OK)
 
+class PositionViewSetTestCase(APITestCase):
+    def setUp(self):
+        self.client = APIClient()
+        self.user = Employee.objects.create_superuser(
+            username='admin',
+            password='testpassword',
+            email='admin@gmail.com'
+        )
+        self.client.force_authenticate(user=self.user)
+        self.department = DepartmentFactory()
+        self.position = PositionFactory(title="Initial Position")
+
+    def test_get_position_list(self):
+        response = self.client.get(reverse('api-hr:position-list'))
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertIn('results', response.data)
+
+    def test_create_position(self):
+        data = {'title': 'New Position', 'department': self.department.pk,}
+        response = self.client.post(reverse('api-hr:position-list'), data)
+        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+        self.assertTrue(
+            PositionFactory._meta.model.objects.filter(title='New Position').exists()
+        )
+
+    def test_retrieve_position(self):
+        response = self.client.get(reverse('api-hr:position-detail', kwargs={'pk': self.position.pk}))
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(response.data['title'], self.position.title)
+
+    def test_update_position(self):
+        data = {'title': 'Updated Position'}
+        response = self.client.patch(
+            reverse('api-hr:position-detail', kwargs={'pk': self.position.pk}),
+            data
+        )
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.position.refresh_from_db()
+        self.assertEqual(self.position.title, 'Updated Position')
+
+    def test_delete_position(self):
+        response = self.client.delete(reverse('api-hr:position-detail', kwargs={'pk': self.position.pk}))
+        self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
+        self.assertFalse(
+            PositionFactory._meta.model.objects.filter(pk=self.position.pk).exists()
+        )