Remove unused argument on CheckedHrpstring::fe32_iter #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
ACK f293b34 |
apoelstra
added a commit
that referenced
this pull request
Aug 2, 2025
7a3f493 ci: update checkout and cache to v4; runner to ubuntu-latest. (Andrew Poelstra) 62a9d53 add weekly cronjob to update nightly-version (Andrew Poelstra) 4c00b93 introduce nightly-version file (copied from rust-bitcoin) and use it in CI (Andrew Poelstra) 720992b clippy: fix new lifetime lint (Andrew Poelstra (aider)) Pull request description: Right now I can't test #220 or #221 locally because clippy is failing with the latest nightly. I can disable the local clippy check but I'd prefer to fix it here. Should unblock both those PRs. ACKs for top commit: clarkmoody: ACK 7a3f493 Tree-SHA512: 725177b18bce543c6c114ce0ee6ef04bc6862c440a2fff9b99d607b912f6ab2c0eab22ecf03abc89332519aa9ffc4ddd624d16abfce0c6d4fefad53a87eb5249
|
Needs rebase since #223 -- sorry, I added an extra lifetime parameter on the same function definition that you're fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve #193 (comment)