Skip to content

Conversation

tcharding
Copy link
Member

Draft till we are ready.

In preparation for release add a changelog entry, bump the version, and update the lock files.

tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Sep 9, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
tcharding added a commit to tcharding/rust-bitcoin that referenced this pull request Sep 9, 2025
Based on the release tracking PR

 rust-bitcoin/rust-secp256k1#843

Just do the build errors, lint warnings done next.
In preparation for release add a changelog entry, bump the version,
and update the lock files.
Copy link
Contributor

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoelstra
Copy link
Member

The only thing blocking this is that I would like to move the Secp256k1 object that we're using in our callback to be private (maybe I can replace it entirely with ffi::Context) and then create a new dummy Secp256k1 object where I can attempt to recreate a deprecated version of the old API.

I wouldn't mind any further API improvements but let's not block this release over it.

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6753b76

Comment on lines +15 to +21
* #811
* #794
* #797
* #798
* #802
* #803
* #805
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the other PRs in this changelog diff have links, why these don't?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks man, nice one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants