Skip to content

Conversation

Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Oct 2, 2025

This adds deny(clippy::missing_trait_methods) on impl that must forward calls to the underlying type. This will avoid issues I fixed #705, #703, #701, and #700.

This allowed me to catch a miss.

@Conaclos Conaclos requested a review from a team as a code owner October 2, 2025 10:22
@Dirbaio
Copy link
Member

Dirbaio commented Oct 2, 2025

does it work if you put #![deny(clippy::missing_trait_methods)] at the crate level? this way there's no noise for each impl, and it's not possible to forget to add it on new impls.

@Conaclos Conaclos force-pushed the lint-adapter branch 2 times, most recently from 64fb23d to 3e52ec7 Compare October 2, 2025 13:13
@Conaclos
Copy link
Contributor Author

Conaclos commented Oct 2, 2025

does it work if you put #![deny(clippy::missing_trait_methods)] at the crate level? this way there's no noise for each impl, and it's not possible to forget to add it on new impls.

Yes. However, it doesn't make sense for some impls, such as Vec and slice, to implement all methods.
I managed to reduce the noise using module-level deny for boxx.rs. I had to separate blanket impl in a dedicated module.

Dirbaio
Dirbaio previously approved these changes Oct 2, 2025
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Dirbaio
Copy link
Member

Dirbaio commented Oct 2, 2025

seems clippy is angry about std impls now

@Conaclos
Copy link
Contributor Author

Conaclos commented Oct 2, 2025

seems clippy is angry about std impls now

I always forgot to pass --all-features to Clippy!
It is now fixed. I had to re-add individual deny for the std adapters.

@Conaclos Conaclos force-pushed the lint-adapter branch 2 times, most recently from 3e92b16 to 2b72166 Compare October 2, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants