Add optional embedded_io::Write impl for Vec.
#586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This'd be a very welcome addition. If embedded-io's stability is a concern, rust-embedded/embedded-hal#566 ("is there anything to add before a 1.0?") would be a discussion that could use some implementators' input. |
sgued
reviewed
Aug 20, 2025
| @@ -176,6 +176,7 @@ jobs: | |||
| cargo check --target="${target}" --features="portable-atomic-critical-section" | |||
| cargo check --target="${target}" --features="serde" | |||
| cargo check --target="${target}" --features="ufmt" | |||
| cargo check --target="${target}" --features="embedded-io" | |||
There was a problem hiding this comment.
Please add the embedded-io feature to the tests and to the miri test runs too
There was a problem hiding this comment.
How do you want this done? None of the other features appears to be tested in this manner, so I'm not sure what you expect.
There was a problem hiding this comment.
Add the embedded-io feature line 51 and 87 of the .github/workflows/build.yml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogous to how
std::vec::Vecimplementsstd::io::Write.