Don't generate invalid non-zero integers #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the instance for `NonZeroUsize` was generating code equivalent to this: ```rust NonZeroUsize::new(u.arbitrary::<usize>()?)? ``` But `u.arbitrary::<usize>()` can generate 0, which will fail.
fitzgen
reviewed
Mar 11, 2025
Contributor
Author
|
@fitzgen Anything else I should change, or is this ready for merge? |
fitzgen
approved these changes
Nov 7, 2025
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay, been traveling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the instance for
NonZeroUsizewas generating code equivalent to this:But
u.arbitrary::<usize>()can generate 0, which will fail.