Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Nov 4, 2025

What does this PR try to resolve?

This came out of #16192 (comment)

How to test and review this PR?

As for testing, I was unsure if it was worth exhaustively testing every variant of every format option

@epage epage added the T-cargo Team: Cargo label Nov 4, 2025
@rustbot rustbot added A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-tree S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@epage
Copy link
Contributor Author

epage commented Nov 4, 2025

@rfcbot fcp merge

This proposes adding to cargo tree --format long forms of each one-letter variable

  • {f}: {features}
  • {p}: {package}
  • {l}: {license}
  • {r}: {repository}

This moves us away from the precedent that everything is short to short forms are a convenience for commonly used items.

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Nov 4, 2025

Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-rfcbot rust-rfcbot added final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels Nov 11, 2025
@rust-rfcbot
Copy link
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@weihanglo weihanglo added this pull request to the merge queue Nov 13, 2025
Merged via the queue into rust-lang:master with commit cd90026 Nov 13, 2025
25 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2025
@epage epage deleted the format branch November 14, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-tree disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken T-cargo Team: Cargo

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants