[win][arm64ec] Fix finding assembler and setting is_arm for Arm64EC #1511
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Aug 9, 2025
dpaoliello
force-pushed
the
arm64ecfixes
branch
from
5e70630 to
281ec7c
Compare
dpaoliello
force-pushed
the
arm64ecfixes
branch
from
281ec7c to
b7bb0c7
Compare
|
Seems like it break the ci on main https://github.com/rust-lang/cc-rs/actions/runs/16855945795/job/47749185799#step:6:1 |
Errr... doesn't seem related to my change. It shouldn't have affected non-MSVC targets... |
|
Hmm... This is for build-std with nightly, did something break in the Rust project? |
|
Maybe? i was thinking if there's some |
|
Took another look, you are right, it's probably a nightly issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.