Add missing C++ ABI linker flag for AIX #1578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyoyo0
force-pushed
the
aix-linker-fix
branch
from
5b99f73 to
0c26f41
Compare
uyoyo0
force-pushed
the
aix-linker-fix
branch
from
0c26f41 to
cb41efc
Compare
|
Hmm does enabling |
It correctly identifies libc++ but the issue is that it fails to identify and link libc++abi which contains symbols for things such as exception handling. |
That's strange, based on my experience of using c++ with gcc/clang, using the c++ compiler automatically link in stdc++ and other stuff required, including exception handling. cc @madsmtm wdyt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a linking failure when building C++ code on AIX. For example, when working with a downstream crate like
cxx,cargo testfails during the linking stage with the following error:The current implementation links against libc++ but we additionally need it to link against libc++abi which is what this patch does.