-
Notifications
You must be signed in to change notification settings - Fork 542
Mark static_flag
and shared_flag
as deprecated
#1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have these functions deprecated, but we cannot just remove them as it would break compatibility and release a 2.0.0 release
emmm, can we create a version 2.0 branch then? i can change the PR target. |
We have absolutely no plan for 2.0, that'll just render too many build script to stick to a 1.0 version so we'd either backport to maintain 1.0 or give them up, which is not realistic |
huh, and people really are using them even if they do nothing. how about i also add a |
Thanks this reminds me, some does use it to build shared lib I think?
Hmmm no that's bad, I'd prefer deprecated if we really want to do that |
it won't work though. all they would get is |
static_flag
and shared_flag
as deprecated
They are meaningless since cc-rs only generates static libraries. Closes rust-lang#1444 Closes rust-lang#594
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
can you fix the semver-checks CI?
I think we would need to add
with:
release-type: minor
to
cc-rs/.github/workflows/main.yml
Line 436 in 1ca8b2a
- name: Check semver |
They are meaningless since cc-rs only generates static libraries. Having them does nothing and only causes confusion.
Closes #1444
Closes #594