- 
                Notifications
    You must be signed in to change notification settings 
- Fork 216
Add registry-watcher image and separate docker-compose services #2269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Probably needs some infra input on the deploy changes (what exactly the tags they use will be). Also I want to investigate the crates.io-index initialization a little more and make sure that's working (and probably have it be local to each container instead of shared as it is now). | 
| Thank you for working on this @Nemo157 ! Sorry for already adding a review in the draft-stage, but I thought some feedback would already help :) | 
9204a09    to
    abd7725      
    Compare
  
    abd7725    to
    17b0ef0      
    Compare
  
    17b0ef0    to
    d5c6f33      
    Compare
  
    | I have removed the CI changes pushing the new image to production, since that will require some input from infra and can be done later. | 
d7978cd    to
    eb357e5      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to fully test yet, but I already have some comments / ideas.
Also I want to investigate the crates.io-index initialization a little more and make sure that's working (and probably have it be local to each container instead of shared as it is now).
Were you able to test if the index clone works without the entrypoint.sh?
| short test result: 
 | 
eb357e5    to
    0366ef5      
    Compare
  
    | Fixed that, I was normalizing the  | 
0366ef5    to
    62d274d      
    Compare
  
    | 
 I'm still seeing the same error when trying to run the registry watcher container? | 
62d274d    to
    5c52738      
    Compare
  
    5c52738    to
    f715373      
    Compare
  
    | 
 Coming back to this finally, are you using  | 
f715373    to
    303eb68      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
- web container
- cli container
- registry watcher
- builder-a
awesome, thank you for keeping to work on it!
Some small documentation comments, and a missing platform.
| You can also run other non-build commands like the setup steps above, or queueing crates for the background builders from within the `cli` container: | ||
|  | ||
| ```sh | ||
| docker compose run --rm cli database migrate | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear that you have to run this command to make the service work.
| context: . | ||
| dockerfile: ./dockerfiles/Dockerfile | ||
| target: build-server | ||
| depends_on: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing the platform: "linux/amd64" definition, or am I missing something?
        
          
                README.md
              
                Outdated
          
        
      | a `registry-watcher` container: | ||
|  | ||
| ```sh | ||
| docker compose run --rm registry-watcher queue set-last-seen-reference --head | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, the command has to be run initially, to be able to use the registry-watcher container at all
303eb68    to
    49b7ed5      
    Compare
  
    | Rebased, and tried to improve the documentation about initial docker compose setup. Turns out the  | 
Creates a separate image for the registry-watcher, setup to run the correct command. Reconfigures the docker-compose setup to use the web-server image and this new registry-watcher image as intended to be used in the new production infrastructure, along with a new build-server image that is close to what will be used in the new production infrastructure, replicated twice.