Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 3, 2025

  1. don't use the std sync channels in this async / sync mix. Tokio's channels can handle the mix better.
  2. use bounded channels so in the case that (for example) the sender is too fast / the receiver to slow, we won't end up in OOM land.
  3. add Send + 'static bounds so I don't do stupid stuff any more (like ensure current tracing span is passed into streaming html rewrite #2874, fix in ensure current tracing span is passed into streaming html rewrite #2974)
  4. errors: try to preserve the context / error chain when we report errors by using the anyhow context, and also our report_error util for sentry.

@syphar syphar requested a review from a team as a code owner November 3, 2025 05:53
@syphar syphar self-assigned this Nov 3, 2025
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 3, 2025
@syphar syphar changed the title small optimizations for streaming html rewrites small optimizations for streaming html rewrite Nov 3, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@syphar syphar merged commit ee2bbaf into rust-lang:master Nov 3, 2025
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 3, 2025
@syphar syphar deleted the opti branch November 3, 2025 10:52
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants