Clean up CLONE_ definitions #4672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-android
O-gnu
O-linux
O-linux-like
O-musl
O-unix
S-waiting-on-review
labels
|
Some changes occurred in the Android module cc @maurer |
This CL moves all `CLONE_` constant definitions into `src/unix/linux_like/mod.rs` as there are no differences between the GNU, MUSL, and Android BIONIC definitions of these constants.
chriswailes
force-pushed
the
clone-opts-all
branch
from
763cd26 to
ac6ad29
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I believe this was a CI hiccup. I ran the following command locally and it worked: The error logs indicate an IO error related to a "Bad address". It is unclear if that is a memory address or a network address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This CL moves all
CLONE_constant definitions intosrc/unix/linux_like/mod.rsas there are no differences between the GNU, MUSL, and Android BIONIC definitions of these constants.Sources
Constant value source: https://github.com/torvalds/linux/blob/master/include/uapi/linux/sched.h
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI