-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ctest: add defines for specific headers and language selection #4673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we add back in the C++ testing in |
FreeBSD is failing in a different way than usual. It might be because |
e019371
to
9555368
Compare
ctest/src/template.rs
Outdated
pub headers: Vec<String>, | ||
pub header_defines: HashMap<String, Vec<String>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of keeping this as separate fields, could headers
instead become Vec<(BoxStr, Vec<BoxStr>)>
? Or put those two fields into a new struct.
This should also allows the same header to be used more than once with a different set of #define
s. Probably not very useful for our purposes, but it does come up in C land.
For reference, this is usually where something like the |
cb0f2e0
to
95badda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
95badda
to
56b05ac
Compare
Description
Allows defining values only for certain headers, as well as choosing which language to use when generating tests.
Closes #4598
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI