Skip to content

Conversation

mbyx
Copy link
Contributor

@mbyx mbyx commented Aug 24, 2025

Description

Blocked on #4674.

Progress:

  • wasi
  • solaris/illumos
  • NetBSD
  • emscripten
  • android

The ioctl function is now skipped on android because the new method of checking function addresses does not work with overloaded functions.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@mbyx
Copy link
Contributor Author

mbyx commented Aug 24, 2025

The error here is caused by constants like J1939_MAX_UNICAST_ADDR, which are only present in the recently added new module. This should only be added if the target is linux and not android. So I'm assuming it's the same issue as before, macro expansion needs to be specified the correct target manually. So most likely, blocked on #4674

@mbyx mbyx force-pushed the libc-test-port-two branch from 12a41e5 to bbd7c59 Compare August 29, 2025 06:29
@rustbot rustbot added the ctest Issues relating to the ctest crate label Aug 29, 2025
@mbyx mbyx force-pushed the libc-test-port-two branch 2 times, most recently from c6be09b to 0d0f93f Compare August 29, 2025 07:02
@rustbot rustbot added the A-CI Area: CI-related items label Aug 29, 2025
@mbyx mbyx force-pushed the libc-test-port-two branch 3 times, most recently from 18f26a2 to 81ecdd0 Compare August 29, 2025 07:14
@mbyx
Copy link
Contributor Author

mbyx commented Aug 29, 2025

On android we can't test the ioctl function anymore because it can't figure out which function we're talking about between the two overloads it has. Previously we would specify the exact type for this reason. I'm skipping it for now, but what should we do for this case?

@mbyx mbyx force-pushed the libc-test-port-two branch 3 times, most recently from aa829af to 5b3049b Compare August 29, 2025 07:54
@mbyx mbyx closed this Aug 29, 2025
@mbyx mbyx reopened this Aug 29, 2025
@mbyx mbyx force-pushed the libc-test-port-two branch 10 times, most recently from 0de66d7 to d385922 Compare August 29, 2025 11:09
@mbyx mbyx marked this pull request as ready for review August 29, 2025 11:20
@mbyx mbyx force-pushed the libc-test-port-two branch from d385922 to c25c889 Compare August 30, 2025 14:35
@tgross35 tgross35 added this pull request to the merge queue Sep 1, 2025
@tgross35
Copy link
Contributor

tgross35 commented Sep 1, 2025

On android we can't test the ioctl function anymore because it can't figure out which function we're talking about between the two overloads it has. Previously we would specify the exact type for this reason. I'm skipping it for now, but what should we do for this case?

I'm not really sure about this one. Could you open a new issue so this doesn't get lost?

Merged via the queue into rust-lang:main with commit 048162d Sep 1, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI-related items ctest Issues relating to the ctest crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants