Skip to content

Conversation

@coolreader18
Copy link
Contributor

Description

There's already can::{raw, j1939}, and this adds bcm.

Sources

https://github.com/torvalds/linux/blob/b320789d6883cc00ac78ce83bccbfe7ed58afcf0/include/uapi/linux/can/bcm.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added O-linux S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 1, 2025
@coolreader18
Copy link
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@tgross35
Copy link
Contributor

Hey, sorry for the delay here. I wanted to require making it explicit that the enum should be anonymous, so I just went ahead and merged that in 02c4d66. Would you be able to update using #anon?

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@coolreader18
Copy link
Contributor Author

@rustbot ready

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but LGTM. Could you please squash the commits?

@tgross35
Copy link
Contributor

Thank you!

@tgross35 tgross35 enabled auto-merge October 22, 2025 20:05
@tgross35 tgross35 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into rust-lang:main with commit 62a1fad Oct 22, 2025
76 of 79 checks passed
@coolreader18 coolreader18 deleted the can_bcm branch October 22, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-linux stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants