Skip to content

Conversation

SwishSwushPow
Copy link

Description

While reviewing dependencies at my company I noticed that with libc 0.2.177 the cherry-pick-stable.sh script showed up in the package published to crates.io. I suspect that it is not required to be shipped and I open this PR to exclude it from the package. This makes code review for supply chain safety a bit easier because we don't have to review future changes to the script and not having a script in the published package is also a good thing. :)

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Since this is targeting 0.2 I think the stable label is warrented? Sorry if I'm getting something wrong here. 😅

@rustbot label +stable-nominated

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against libc-0.2. Please double check that you specified the right target!

@JohnTitor JohnTitor force-pushed the exlcude-cherry-pick-script branch from f1e81fe to e00110f Compare October 21, 2025 22:13
@JohnTitor JohnTitor removed the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 21, 2025
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@JohnTitor
Copy link
Member

Since this is targeting 0.2 I think the stable label is warrented? Sorry if I'm getting something wrong here.

The label is used when a PR should be backported to 0.2 from main, so it's unnecessary in this case. But anyway thanks for caring :)

@JohnTitor JohnTitor enabled auto-merge October 21, 2025 22:15
@JohnTitor JohnTitor added this pull request to the merge queue Oct 21, 2025
Merged via the queue into rust-lang:libc-0.2 with commit 034e4f3 Oct 21, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants