-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove rogue definition of SIGSTKFLT for mips32-linux-musl #4749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Relevant musl commit was:
Interestingly enough, on OpenWrt's SDK it only fails under 64-bit MIPS. Sounds like the libc crate is broken. edit: nvm. |
This comment has been minimized.
This comment has been minimized.
c26a1d2
to
6e6d0b4
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching this! Yeah, it seems it was introduced mistakenly in the past and has been removed at somewhere. Makes sense.
Linux' arch/mips/include/uapi/asm/signal.h does not define SIGSTKFLT. For one MIPS architecture, we define it as 7 for unknown reasons, but 7 is already SIGEMT. This is confusing and probably useless. Remove it. [ squashed JohnTitor's commit deleting the changelog entry - Trevor ]
6e6d0b4
to
d288386
Compare
It's a tier 3 target and the musl patch was applied (kraj/musl@cabc369) so we can just backport this. @rustbot label +stable-nominated (used the CI failure as an opportunity to squash the commit, so we don't get a conflict on backport) |
Linux' arch/mips/include/uapi/asm/signal.h does not define SIGSTKFLT.
For one MIPS architecture, we define it as 7 for unknown reasons,
but 7 is already SIGEMT. This was confusing and is probably useless.
Remove it.