Various fixes to the file related shims #983
Conversation
pvdrz
changed the title
pvdrz
force-pushed
the
fs-shims-tweaks
branch
from
cb51e7d to
12040aa
Compare
|
Could you also rename the "file_manipulation.rs" test to "fs.rs"? That corresponds with the libstd module it tests. |
|
I think we should stop this PR here and review that all the changes are adequate. This is getting too large. |
|
So, removing the WIP then? |
pvdrz
changed the title
|
Looking good aside from the nits. |
|
Great, I'm baking another fix in the oven. Let me finish that one and I'll do this one next |
|
I ran rustfmt by mistake, but its the last commit D: sorry |
pvdrz
force-pushed
the
fs-shims-tweaks
branch
from
586d93a to
46db93a
Compare
Won't this cause conflicts with all your other PRs? (And make reviewing painful.) |
|
Oh, the last commit is rustfmt plus other stuff. Please fix that. |
pvdrz
force-pushed
the
fs-shims-tweaks
branch
from
46db93a to
003b257
Compare
|
Ok, we are good to go. |
|
Thanks! @bors r+ if you want to make PR with only rustfmt changes, I'd be up for that as well. But beware of conflicts. |
|
📌 Commit 003b257 has been approved by |
Various fixes to the file related shims Hi @RalfJung, I'll be working incrementally over your comments for the new `fs` shims module here.
|
☀️ Test successful - checks-travis, status-appveyor |
4 participants
Hi @RalfJung, I'll be working incrementally over your comments for the new
fsshims module here.