Skip to content

fix: offer invert_if on else #20771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix: offer invert_if on else #20771

merged 1 commit into from
Oct 22, 2025
+12 −1

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Oct 1, 2025

Example

fn f() {
    if cond {
        3 * 2
    } e$0lse {
        1
    }
}

->

fn f() {
    if !cond {
        1
    } else {
        3 * 2
    }
}

@A4-Tacks
Add applicable on else for invert_if
c4586bd 
Example
---
```rust
fn f() {
    if cond {
        3 * 2
    } e$0lse {
        1
    }
}
```
->
```rust
fn f() {
    if !cond {
        1
    } else {
        3 * 2
    }
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2025
ChayimFriedman2
ChayimFriedman2 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's better, but it's also not particularly worse.

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into rust-lang:master with commit 9fd6be3 Oct 22, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2025
@A4-Tacks A4-Tacks deleted the else-kw-invert-if branch October 22, 2025 03:17
@lnicola lnicola changed the title Add applicable on else for invert_if fix: offer invert_if on else Oct 24, 2025
mendelsshop pushed a commit to mendelsshop/rust-analyzer that referenced this pull request Oct 27, 2025
@ChayimFriedman2
Merge pull request rust-lang#20771 from A4-Tacks/else-kw-invert-if
f7a7ed8 
Add applicable on `else` for invert_if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @ChayimFriedman2 @rustbot