-
Notifications
You must be signed in to change notification settings - Fork 763
Add ParseCallbacks::allow_item() and ParseCallbacks::block_item(). #3245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicopauss
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
Intersec:intersec/add-parse-callbacks-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
bindgen-tests/tests/expectations/tests/allow-item-callback.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
52 changes: 52 additions & 0 deletions
52
bindgen-tests/tests/expectations/tests/block-item-callback.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// bindgen-parse-callbacks: allow-item | ||
|
||
struct allowed_my_struct { | ||
int a; | ||
}; | ||
|
||
union allowed_my_union { | ||
int a; | ||
double b; | ||
}; | ||
|
||
enum allowed_my_enum { | ||
ALLOWED_MY_ENUM_A, | ||
ALLOWED_MY_ENUM_B, | ||
}; | ||
|
||
static const int allowed_my_const = 10; | ||
|
||
struct non_allowed_my_struct { | ||
int a; | ||
}; | ||
|
||
union non_allowed_my_union { | ||
int a; | ||
double b; | ||
}; | ||
|
||
enum non_allowed_my_enum { | ||
NON_ALLOWED_MY_ENUM_A, | ||
NON_ALLOWED_MY_ENUM_B, | ||
}; | ||
|
||
static const int non_allowed_my_const = 10; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// bindgen-parse-callbacks: block-item | ||
|
||
struct blocked_my_struct { | ||
int a; | ||
}; | ||
|
||
union blocked_my_union { | ||
int a; | ||
double b; | ||
}; | ||
|
||
enum blocked_my_enum { | ||
BLOCKED_MY_ENUM_A, | ||
BLOCKED_MY_ENUM_B, | ||
}; | ||
|
||
static const int blocked_my_const = 10; | ||
|
||
struct non_blocked_my_struct { | ||
int a; | ||
}; | ||
|
||
union non_blocked_my_union { | ||
int a; | ||
double b; | ||
}; | ||
|
||
enum non_blocked_my_enum { | ||
NON_BLOCKED_MY_ENUM_A, | ||
NON_BLOCKED_MY_ENUM_B, | ||
}; | ||
|
||
static const int non_blocked_my_const = 10; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behavior if both of these return true for an item? Will it be allowed or blocked? Seems like bad design to allow such conflicting option in the API (I realize this is already allowed by the current allowlist / blocklist regexes, such is life ...)
Could this API look something like:
and then in parse callbacks, have:
Where a None return means "no override" and a Some means allow or block, per the returned value?
Bonus points if you can only call the callback once instead of twice.
I'm very new to bindgen codebase, just some ideas, take with a grain of salt etc.