Skip to content

Conversation

GnomedDev
Copy link
Contributor

@GnomedDev GnomedDev commented Oct 19, 2024

This is currently draft as built on-top of #13557.

Closes #12290.

This is implemented by inspecting rustc's NeverToAny type adjustments, meaning we do not have to solve the halting problem ourselves (that's rustc's job).

I've chosen pedantic as:

  • Users may want to avoid the magic of !
  • It doesn't make a significant performance/readability improvement
  • It can be noisy, especially during development.

@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 19, 2024
@GnomedDev GnomedDev marked this pull request as draft October 19, 2024 00:43
@GnomedDev GnomedDev force-pushed the never-return branch 2 times, most recently from e5fe67a to 2da4866 Compare October 19, 2024 10:59
@bors
Copy link
Contributor

bors commented Oct 21, 2024

☔ The latest upstream changes (presumably #13567) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Nov 2, 2024

☔ The latest upstream changes (presumably #13376) made this pull request unmergeable. Please resolve the merge conflicts.

@Alexendoo Alexendoo added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho
Copy link
Contributor

Jarcho commented Sep 17, 2025

Closing since #13557 has also been closed.

@Jarcho Jarcho closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggest ! return type for functions that never return a value

5 participants