Skip to content

Fix FP of needless_range_loop when meeting multidimensional array #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix FP of needless_range_loop when meeting multidimensional array #15486

wants to merge 1 commit into from

Conversation

relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Aug 14, 2025 •
edited
Loading

Fixes #15068

changelog: Fix [needless_range_loop] false positive and false negative when meeting multidimensional array

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 14, 2025
Jarcho
Jarcho requested changes Aug 15, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 15, 2025
@relaxcn
Copy link
Contributor Author

relaxcn commented Aug 25, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needless_range_loop falsely emmitted with nested indexing
3 participants
@relaxcn @rustbot @Jarcho