unit_cmp: don't lint on explicitly written unit expr
#15562
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: [`unit_cmp`]: don't lint on explicitly written unit expr Signed-off-by: Zihan <zihanli0822@gmail.com>
rustbot
added
the
S-waiting-on-review
samueltardieu
requested changes
Aug 26, 2025
There was a problem hiding this comment.
Some small comments, otherwise it looks fine!
r? samueltardieu
@rustbot author
| @@ -68,3 +68,17 @@ fn main() { | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| fn issue15559() { | |||
| fn foo() {} | |||
There was a problem hiding this comment.
Since we're at it, please add a test for assert_eq!(foo(), foo()).
Comment on lines
+22
to
+25
| if !cx.typeck_results().expr_ty(lhs).is_unit() { | ||
| return; | ||
| } | ||
| if is_unit_expr(lhs) || is_unit_expr(rhs) { |
There was a problem hiding this comment.
Please switch those tests, is_unit_expr() is cheaper than expr_ty(), so is_unit_expr() should go first.
samueltardieu
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15559
changelog: [
unit_cmp]: don't lint on explicitly written unit expr