Allow explicit_write in tests
#15862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ada4a
suggested changes
Oct 11, 2025
Comment on lines
+55
to
+58
| if is_in_test(cx.tcx, expr.hir_id) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
You could pull this into the let-chain
There was a problem hiding this comment.
I was afraid that would confuse the logic. If it's okay, I'd like to wait and see what @Jarcho says.
smoelius
force-pushed
the
allow-explicit-write-in-tests
branch
from
720f1f5 to
1eb9a09
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15780.
I didn't get any feedback on that issue. So I hope it is okay that I charged ahead and addressed it.
changelog: Allow
explicit_writein tests