Skip to content

Remove misc_cast and validate types when casting #103122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Remove misc_cast and validate types when casting #103122

merged 1 commit into from
Oct 25, 2022

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Oct 16, 2022

Continuing our work in #102675

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
RalfJung
RalfJung reviewed Oct 19, 2022
View reviewed changes
RalfJung
RalfJung reviewed Oct 19, 2022
View reviewed changes
RalfJung
RalfJung reviewed Oct 19, 2022
View reviewed changes
RalfJung
RalfJung reviewed Oct 20, 2022
View reviewed changes
compiler/rustc_const_eval/src/interpret/cast.rs Outdated
@@ -143,18 +169,18 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
return Ok(self.cast_from_float(src.to_scalar().to_f64()?, cast_ty).into());
}
// The rest is integer/pointer-"like", including fn ptr casts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The rest is integer/pointer-"like", including fn ptr casts

@RalfJung
Copy link
Member

LGTM with that last comment fixed.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 21, 2022

@bors delegate+

r=oli-obk,RalfJung with the commits squashed

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

✌️ @ouz-a can now approve this pull request

@ouz-a ouz-a force-pushed the mir-technical-debt branch from a19a1d9 to cc1407f Compare October 21, 2022 09:51
@ouz-a
Copy link
Contributor Author

ouz-a commented Oct 21, 2022

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

📌 Commit cc1407f has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk
24d17ef 
Remove misc_cast and validate types when casting

Continuing our work in rust-lang#102675

r? `@oli-obk`
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 22, 2022
Closed
@Dylan-DPC
Copy link
Member

failed in rollup
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2022
@RalfJung
Copy link
Member

Ah, Miri needs to be patched as well. You can test this locally with ./x.py check src/tools/miri.

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2022

The Miri subtree was changed

cc @rust-lang/miri

@ouz-a ouz-a force-pushed the mir-technical-debt branch from c2446fd to 4bd9844 Compare October 23, 2022 15:47
@ouz-a
Copy link
Contributor Author

ouz-a commented Oct 23, 2022

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Oct 23, 2022

📌 Commit 4bd9844 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk
60f3f07 
Remove misc_cast and validate types when casting

Continuing our work in rust-lang#102675

r? `@oli-obk`
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 24, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 25, 2022
@Dylan-DPC
Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk
1c8201c 
Remove misc_cast and validate types when casting

Continuing our work in rust-lang#102675

r? ``@oli-obk``
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 25, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 25, 2022
@Dylan-DPC
Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk
ee05439 
Remove misc_cast and validate types when casting

Continuing our work in rust-lang#102675

r? ```@oli-obk```
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 25, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2022
@bors
Auto merge of rust-lang#103513 - Dylan-DPC:rollup-nn3ite2, r=Dylan-DPC
c6bd7e2 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#98204 (Stabilize `Option::unzip()`)
 - rust-lang#102587 (rustc: Use `unix_sigpipe` instead of `rustc_driver::set_sigpipe_handler`)
 - rust-lang#103122 (Remove misc_cast and validate types when casting)
 - rust-lang#103379 (Truncate thread names on Linux and Apple targets)
 - rust-lang#103482 (Clairify Vec::capacity docs)
 - rust-lang#103511 (Codegen tweaks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ba2a65 into rust-lang:master Oct 25, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 25, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@Dylan-DPC
Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk
9e2be77 
Remove misc_cast and validate types when casting

Continuing our work in rust-lang#102675

r? ````@oli-obk````
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103513 - Dylan-DPC:rollup-nn3ite2, r=Dylan-DPC
7749251 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#98204 (Stabilize `Option::unzip()`)
 - rust-lang#102587 (rustc: Use `unix_sigpipe` instead of `rustc_driver::set_sigpipe_handler`)
 - rust-lang#103122 (Remove misc_cast and validate types when casting)
 - rust-lang#103379 (Truncate thread names on Linux and Apple targets)
 - rust-lang#103482 (Clairify Vec::capacity docs)
 - rust-lang#103511 (Codegen tweaks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@ouz-a ouz-a deleted the mir-technical-debt branch July 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ouz-a @rustbot @RalfJung @oli-obk @bors @Dylan-DPC @rust-highfive