Rollup of 8 pull requests #104293
Merged
Rollup of 8 pull requests #104293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the `Linker::{link_whole_staticlib,link_whole_rlib}`
methods for the `WasmLd` linker used on wasm targets. Previously these
methods were noops since I think historically `wasm-ld` did not have
support for `--whole-archive` but nowadays it does, so the flags are
passed through.
explain how to go back to rustup-managed Miri Fixes rust-lang/miri#2633
./miri updates: toolchain, rustc-push, rustc-pull This merges the `./rustup-toolchain` script into `./miri` as `./miri toolchain`, and adds two new commands for josh-based syncing. r? `@rust-lang/miri`
Stacked Borrows: make scalar field retagging the default I think it is time to finally close this soundness gap. Any objections? :) Unfortunately the latest released versions of hashbrown and scopeguard can fail under full field retagging. The fixes have landed in the git repos but have not been released yet. I don't know if scalar field retagging as enabled by this PR is sufficient to cause problems with these crates, but it seems likely that this would be the case -- e.g. if both `value` and `dropfn` are scalars, the entire scopeguard struct will be a `ScalarPair` and thus get field retagging. However, given that we actually generate LLVM `noalias` for these cases, it seems prudent to inform users of this risk. They can easily set `-Zmiri-field-retag=none` to opt-out of this change. Cc rust-lang/miri#2528
Fix dupe word typos
…Jung Followup for pr 2640 r? `@RalfJung`
fix ./miri bench Fixes rust-lang/miri#2643
InitOnce: synchronize with completion when already complete The completion of an InitOnce happens-before the threads waiting on it wake up. However, this is not the case for threads that call `InitOnceBeginInitialize` after the completion, leading to data races and outdated weak memory loads as observed in the CI for rust-lang#2638. This PR fixes this.
…ve, r=estebank
Implement the `+whole-archive` modifier for `wasm-ld`
This implements the `Linker::{link_whole_staticlib,link_whole_rlib}` methods for the `WasmLd` linker used on wasm targets. Previously these methods were noops since I think historically `wasm-ld` did not have support for `--whole-archive` but nowadays it does, so the flags are passed through.
…-parentheses, r=estebank Fix unused lint and parser caring about spaces to won't produce invalid code Fixes rust-lang#103435
…tebank Suggest calling the instance method of the same name when method not found Fixes rust-lang#103474
…idtwco piece of diagnostic migrate r? `@davidtwco`
update Miri Notable PRs: - rust-lang/miri#2636 - rust-lang/miri#2641 - rust-lang/miri#2638
…ble-trait, r=Manishearth rustdoc: use javascript to layout notable traits popups Fixes rust-lang#102576 Preview: https://notriddle.com/notriddle-rustdoc-demos/102576-js-notable-trait/std/iter/trait.Iterator.html#method.step_by ## Before  ## After 
rustbot
added
A-translation
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 7d85104b96 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 11, 2022
|
Finished benchmarking commit (42325c5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This was referenced Nov 14, 2022
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Sizedcoinductive, again #100386 (MakeSizedcoinductive, again)+whole-archivemodifier forwasm-ld#102215 (Implement the+whole-archivemodifier forwasm-ld)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup