Convert a hard-warning about named static lifetimes into lint "unused_lifetimes" #108230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
LittleFall
changed the title
named_static_lifetimes lint
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 21, 2023
…bank Convert a hard-warning about named static lifetimes into lint "unused_lifetimes" Fixes rust-lang#96956. Some changes are ported from rust-lang#98079, thanks to jeremydavis519. r? `@estebank` `@petrochenkov` Any feedback is appreciated! ## Actions - [x] resolve conflicts - [x] fix build - [x] address review comments in last pr - [x] update tests
|
@bors r- Can you squash these into one commit? The presence of 17a7ccc is a bit disorienting to the commit history. Thanks! For context, we don't allow merge commits in the history: https://github.com/rust-lang/rustc-dev-guide/blob/master/src/git.md#keeping-things-up-to-date |
bors
added
S-waiting-on-author
…_lifetimes" Define the `named_static_lifetimes` lint This lint will replace the existing hard-warning. Replace the named static lifetime hard-warning with the new lint Update the UI tests for the `named_static_lifetimes` lint Remove the direct dependency on `rustc_lint_defs` fix build Signed-off-by: Zhi Qi <qizhi@pingcap.com> use "UNUSED_LIFETIMES" instead Signed-off-by: Zhi Qi <qizhi@pingcap.com> update 1 test and fix typo Signed-off-by: Zhi Qi <qizhi@pingcap.com> update tests Signed-off-by: Zhi Qi <qizhi@pingcap.com> fix tests: add extra blank line Signed-off-by: Zhi Qi <qizhi@pingcap.com>
LittleFall
force-pushed
the
enhance/warning
branch
from
5fb9c8b to
ce2ae62
Compare
Got and done. I have cherry-picked actual commits and squashed them into single. |
|
Thank you, sorry for the inconvenience. @bors r=estebank |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2023
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#108110 (Move some `InferCtxt` methods to `EvalCtxt` in new solver) - rust-lang#108168 (Fix ICE on type alias in recursion) - rust-lang#108230 (Convert a hard-warning about named static lifetimes into lint "unused_lifetimes") - rust-lang#108239 (Fix overlapping spans in removing extra arguments) - rust-lang#108246 (Add an InstCombine for redundant casts) - rust-lang#108264 (no-fail-fast support for tool testsuites) - rust-lang#108310 (rustdoc: Fix duplicated attributes for first reexport) - rust-lang#108318 (Remove unused FileDesc::get_cloexec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96956.
Some changes are ported from #98079, thanks to jeremydavis519.
r? @estebank @petrochenkov
Any feedback is appreciated!
Actions